search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

Pip fixes #211

Closed manodeep closed 4 years ago

manodeep commented 4 years ago

Still fixing #208

manodeep commented 4 years ago

Huh - weird! I would have thought that the #209 would have already accounted for the initial commits on this branch.

pep8speaks commented 4 years ago

Hello @manodeep! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-01-30 20:09:51 UTC
lgarrison commented 4 years ago

Weird about the commits, maybe because we're "reusing" the same branch as the first PR?

manodeep commented 4 years ago

@lgarrison Thanks for fixing up the PR. Since the common.mk file has to be read in first any replacements, I moved the this_python substitution back down to after the python validation (i.e., where that section was previously)

manodeep commented 4 years ago

Codacy Here is an overview of what got changed by this pull request:


Issues
======
+ Solved 1

Complexity decreasing per file
==============================
+ setup.py  -3

See the complete overview on Codacy

manodeep commented 4 years ago

@lgarrison Is this okay to merge?

(I am thinking of rebasing and merging - rather than the usual squash-merge)

lgarrison commented 4 years ago

Yes, looks good! Either squash or rebase is fine with me, I don't understand the difference well enough to have a strong opinion!