search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

Update common.mk #230

Closed beckermr closed 3 years ago

lgarrison commented 3 years ago

Thanks! Was sysconfig.get_config_var(x) coming up None for some variable? Do you know which variable and Python environment?

beckermr commented 3 years ago

It is on pypy, not cpython.

lgarrison commented 3 years ago

Good to know, I haven't used PyPy myself, nor do we have any tests for it.

@manodeep Do we want to be really thorough and start doing PyPy tests? Or figure that users will report problems if they find any...

beckermr commented 3 years ago

Yeah no need to worry about pypy. It is a corner case. I was trying a patch on the build but it is not working on osx. I am going to close this PR and just skip pypy.