manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

Add runtime environment check for NERSC Cray hugepages #246

Closed lgarrison closed 3 years ago

lgarrison commented 3 years ago

As discussed in #244 and #245. The runtime check is called from __init__.py, which avoids having to put the check inside each Python module.

I tested this at NERSC and it works as expected, with and without the hugepages module loaded.

pep8speaks commented 3 years ago

Hello @lgarrison! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-04-15 21:54:32 UTC
lgarrison commented 3 years ago

@manodeep Looks like some unrelated build failures, any idea what changed?

manodeep commented 3 years ago

Ahh yes - GH replaced their default pre-installed tools and some combinations of OS + compiler now fail. They apparently update the list of tools ~weekly, with the latest list of tools listed here. From what I can see:

Are you okay to fix these build failures?

manodeep commented 3 years ago

@lgarrison Should the astropy-bot have run on this PR?

lgarrison commented 3 years ago

Yeah, no sign of Astropy bot yet. Thanks for linking the docs, I should be good to fix the failures, fingers crossed!

lgarrison commented 3 years ago

@manodeep Tests are passing, okay to merge?

manodeep commented 3 years ago

Yup - done now :)

Do you want to delete the branch?