Closed lgarrison closed 3 years ago
Hello @lgarrison! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
@manodeep Looks like some unrelated build failures, any idea what changed?
Ahh yes - GH replaced their default pre-installed tools and some combinations of OS + compiler now fail. They apparently update the list of tools ~weekly, with the latest list of tools listed here. From what I can see:
Are you okay to fix these build failures?
@lgarrison Should the astropy-bot have run on this PR?
Yeah, no sign of Astropy bot yet. Thanks for linking the docs, I should be good to fix the failures, fingers crossed!
@manodeep Tests are passing, okay to merge?
Yup - done now :)
Do you want to delete the branch?
As discussed in #244 and #245. The runtime check is called from
__init__.py
, which avoids having to put the check inside each Python module.I tested this at NERSC and it works as expected, with and without the hugepages module loaded.