search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

Fix parsing error when periodic=False and boxsize not given in the theory module #257

Closed lgarrison closed 2 years ago

lgarrison commented 2 years ago

From #256, don't pass a boxsize of None to the C extensions.

pep8speaks commented 2 years ago

Hello @lgarrison! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-09-10 22:42:49 UTC
manodeep commented 2 years ago

Unsure why the astropy bots are complaining - the milestone is set and a changelog entry is present.

manodeep commented 2 years ago

@lgarrison This is ready to merge right?

lgarrison commented 2 years ago

Yes!