Open lgarrison opened 3 years ago
I am confused - if a matching numpy is not present at the build_ext
stage, then shouldn't the install fail? (I see that we need better handling of missing numpy case within common.mk
but that's a separate issue). About building wheels, I thought we can't build/distribute wheels because of #236 and incompatible package name (Corrfunc
instead of corrfunc
) right?
We do need to upgrade our setup machinery - it's been creaking along for many years now :)
While fixing the build failures (#290), I upgraded the minimum python version to py3.7. That means a bunch of the os.path
etc routines can now be replaced with Pathlib.Path
routines
setup_requires
is deprecated; we'll need to migrate to PEP 517/pyproject.toml
.There's a related failure in the wheel build: if numpy is not installed when
pip install corrfunc
is run, then the Python CFLAGS aren't found. In the full log below, it first tries to build a wheel, which fails, and then it succeeds with the legacysetup.py install
method. I think we can probably fix this as part of the PEP 517 migration.