search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

Removed cz fixing for comoving distances #275

Closed misharash closed 2 years ago

misharash commented 2 years ago

When is_comoving_dist is set, cz is actually comoving distance, therefore fixing the inputs by speed of light doesn't make sense, as simplest resolution of this problem I don't set fix_cz then. Fixes #274.

manodeep commented 2 years ago

@misharash Thanks for that. Do you mind adding an entry to the Changelog - something to the effect of "Only perform z vs cz check if co-moving distance is not set"

@lgarrison Good to merge?

misharash commented 2 years ago

Sure, added a line to the changelog under 2.5.0 fixes.

lgarrison commented 2 years ago

I'm traveling right now but will check this on Friday!

On Thu, May 12, 2022, 12:45 AM misharash @.***> wrote:

Sure, added a line to the changelog under 2.5.0 fixes.

— Reply to this email directly, view it on GitHub https://github.com/manodeep/Corrfunc/pull/275#issuecomment-1124524713, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABLA7S2L3LB7PRPLBVQJ3I3VJSEFXANCNFSM5VTQOPHQ . You are receiving this because you were mentioned.Message ID: @.***>

manodeep commented 2 years ago

Thanks for the fix @misharash