manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

First commit for NEON ISA for `DD` #280

Closed manodeep closed 1 year ago

manodeep commented 1 year ago

Both rpavg and weightavg are wrong and the tests fail locally. The good news is that the number of pairs match

Added a checklist for the PR

lgarrison commented 1 year ago

Cool! Will take a look. How's the performance compared to fallback?

manodeep commented 1 year ago

It's a bit of a mixed bag. In single-precision - 3.6s with NEON and 5.8s with FALLBACK, while the times are about the same in double-precision.

manodeep commented 1 year ago

Realised that we have run out of Travis CI build minutes and no tests have run on TravisCI for nearly a year now. Hence, the arm64 tests will have to be done on some other CI -> currently trying out CircleCI

manodeep commented 1 year ago

I am trying out a bunch of new optimisations along side this ARM64 implementation - might take a while to finalise. Will re-open once ready