Closed lgarrison closed 1 year ago
@manodeep Looks like the MacOS jobs are failing, unrelated to this PR. Maybe the macos-latest
image got updated and broke something. Could you take a look?
@lgarrison Looks good to me. Just had one comment about using our favoured python -m pip
rather than pip
directly.
Semi-related, I did not get any email notification for the build failure. Did you?
Yes, I did get the emails, I guess only the PR author gets them. Thanks for the OSX fix; I'll merge as soon as the tests pass!
Also update test instructions on RTD. From #288.