search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
163 stars 50 forks source link

Updated GitHub CI #291

Closed manodeep closed 1 year ago

manodeep commented 1 year ago

Upgraded min python and numpy versions, and changed the compiler versions and the linux os's tested

manodeep commented 1 year ago

Need to add Changelog. Not sure why the astropy bot is not running

manodeep commented 1 year ago

Thanks @lgarrison. Nothing in particular, figured it would be better to test out the recent python and numpy versions - that's where I would expect things to break, if at all.

manodeep commented 1 year ago

@lgarrison Do we not have the astropy milestones checker bot anymore?

lgarrison commented 1 year ago

I guess not. It looks like astropy has migrated to GH actions instead. E.g. for changelog checking: https://github.com/astropy/astropy/blob/main/.github/workflows/check_changelog.yml, with the bot living at https://github.com/pllim/actions-towncrier-changelog

manodeep commented 1 year ago

Fixed the conflict in the changelog.

Looks like we would need to migrate to pyproject.toml before we can use towncrier and allied actions. That's beyond my knowledge - do you know how to do that?

manodeep commented 1 year ago

@lgarrison Okay to merge?

lgarrison commented 1 year ago

Yep, LGTM!

For pyproject.toml, in theory it's not too hard to set up while still keeping most of the work in setup.py, but the Corrfunc build has enough quirks/customizations that it would need some careful testing before we deploy anything. But towncrier might not actually need a fully-fledged toml file; maybe it just needs the sections relevant to it?