search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
167 stars 53 forks source link

mocks: warn about small theta and large mu in float32 precision #299

Closed lgarrison closed 1 year ago

lgarrison commented 1 year ago

From https://github.com/manodeep/Corrfunc/pull/297#issuecomment-1605773449.

Not sure if we should include the mu warning; a user is unlikely to be splitting hairs about the exact mu value above 0.98 like they would small theta. @manodeep what do you think?

manodeep commented 1 year ago

This looks great! Do you want to add the update to the Changelog?

manodeep commented 1 year ago

Ohh also your name isn't on the author list for the files - do you want to fix that up (or in a separate PR)? You should probably be the first author on all the python wrappers :) !

lgarrison commented 1 year ago

I updated the warning and the changelog. No need for my name to be in the authors list for each file; I don't really see that in wide use in Python projects, and being mentioned in the readme/papers is plenty of credit!

lgarrison commented 1 year ago

LGTM!