search

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
167 stars 53 forks source link

CI failure for python 2.7 #320

Closed manodeep closed 3 months ago

manodeep commented 4 months ago

General information

Issue description

The latest dependabot PR highlighted that CI is not running on osx-arm64 for python2.7. Given that Corrfunc supports python2.7, CI should run

Expected behavior

CI runs

Actual behavior

CI fails on osx-arm64. One failure is for py2.7, while others are for py3.7 and numpy1.16

What have you tried so far?

N/A

Minimal failing example

N/A

@lgarrison Maybe it's time to drop python2.7 and adopt a policy to update the minimum versions of required dependencies.

lgarrison commented 4 months ago

+1 for dropping Python 2.7! I usually target non-EOL Python releases (currently 3.8-3.12) in my projects. I doubt we've made any changes that would directly affect the minimum versions of other dependencies, but if we bump the minimum Python version, we might at least need to bump the minimum NumPy version.

manodeep commented 4 months ago

I asked on Twitter - in case someone has a real strong need/justification for python2.7

manodeep commented 4 months ago

(Completely biased) Twitter sample of two (so far) suggests that dropping py2.7 is fine

manodeep commented 3 months ago

Python2.7 has been dropped from the CI - so this issue is fixed (more accurately, not relevant)