Identical z-positions for different particles triggers double counting

manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.

https://corrfunc.readthedocs.io

MIT License

167 stars 51 forks source link

Identical z-positions for different particles triggers double counting #50

Closed manodeep closed 8 years ago

manodeep commented 8 years ago

Affects very low number of particles (obviously). wp and xi are affected

manodeep commented 8 years ago

This is still not fixed -- since dz could be 0.0 for different x/y cells (i.e., where index1 != index2)

manodeep commented 8 years ago

Fix for wp is now in v2.0 branch. Fixing xi in v2.0 and then will merge in.

manodeep commented 8 years ago

Fixed for xi with 13b454f24b38a92a71726477994a7e406f1e0c3c. Need to pull these from v2.0 branch into master before I can close this issue.

Conveniently, both wp and xi are now 20% faster. Scaling can be further improved by changing the order in which ngb_cells are added in gridlink_index in utils/gridlink.c