manodeep / Corrfunc

⚡️⚡️⚡️Blazing fast correlation functions on the CPU.
https://corrfunc.readthedocs.io
MIT License
164 stars 50 forks source link

Max. redshift limit can be exceeded easily for mocks #85

Closed manodeep closed 7 years ago

manodeep commented 7 years ago

Currently the max. redshift is hardcoded in set_cosmo_dist.h as 1.0. For arbitrary datasets, this can be easily exceeded. This limit is actually un-necessary since the set_cosmo_dist function itself takes a parameter for max redshift.

Fix would require calculating the max redshift of the input cz arrays and passing that into set_cosmo_dist or equivalent. This step would obviously be skipped is is_comoving_dist is set.