Undefined global variables

manoelcampos / xml2lua

XML Parser written entirely in Lua that works for Lua 5.1+. Convert XML to and from Lua Tables 🌖💱

MIT License

290 stars 74 forks source link

Closed RussDragon closed 6 years ago

RussDragon commented 6 years ago

Hello, I found two weird variables in the XmlParser.lua (https://github.com/manoelcampos/xml2lua/blob/master/XmlParser.lua#L63 and 64). I couldn't find their usage in code and also found only local definition in xml2lua. I have a feeling that there is something wrong.

Am I right? Is it possible to remove them or make local?

manoelcampos commented 6 years ago

decimalToHtmlChar and hexadecimalToHtmlChar are functions inside the xml2lua.lua file. They just need to be moved to the XmlParser.lua

RussDragon commented 6 years ago

Can you do it, please? Or I can create PR.