search

manogi / nova-tiptap

Laravel Nova Tiptap Field
MIT License
172 stars 57 forks source link

Missing return type -> Different signature than parent #77

Closed bastianschwarz closed 7 months ago

bastianschwarz commented 7 months ago

Hey there,

looks like the current 3.2.2 tag is missing the return type which breaks Nova as the Nova Parent has array as return type. It's present in master so I assume this was a mistake? 3.2.1 is still working.

https://github.com/manogi/nova-tiptap/blob/ec5a4a4ef69d7112db97536fcd14abe5dec664fb/src/Tiptap.php#L216

manogi commented 7 months ago

Hi there - if you PR it I will merge it, thanks.

bastianschwarz commented 7 months ago

Not sure what to PR ... as I said: It's correct in master. Not sure how it got missing in 3.2.2 release. Is it possible the 3.2.2 was created from the wrong branch?

manogi commented 7 months ago

Ah yes - that was it. I actually removed the Release, but the Tag still exists. I am going to overwrite it with a 3.2.3.

manogi commented 7 months ago

3.2.3 is now released - sorry for the inconvenience.

bastianschwarz commented 7 months ago

No worries, I guess we've all done that at least once :D

Thanks for the quick release