manoharan-lab / holopy

Hologram processing and light scattering in python
GNU General Public License v3.0
135 stars 50 forks source link

What unit is used for propagation distances? #274

Closed rgov closed 5 years ago

rgov commented 5 years ago

The docs for propagate() say:

d (float or list of floats) – Distance to propagate, in meters, or desired schema.

but the tutorial says:

Next, we use numpy’s linspace to define a set of distances between the image plane and the reconstruction plane at 2-micron intervals to propagate our image to.

The code given generates this array of distances:

array([ 0.,  2.,  4.,  6.,  8., 10., 12., 14., 16., 18., 20.])
barkls commented 5 years ago

In general, HoloPy is agnostic to units. In this case units are determined by those used to define image spacing and illumination wavelength. the docstring shouldn't mention metres.

On Wed, Jun 19, 2019, 11:20 Ryan Govostes notifications@github.com wrote:

The docs for propagate() say:

d (float or list of floats) – Distance to propagate, in meters, or desired schema.

but the tutorial https://holopy.readthedocs.io/en/master/users/recon_tutorial.html says:

Next, we use numpy’s linspace to define a set of distances between the image plane and the reconstruction plane at 2-micron intervals to propagate our image to.

The code given generates this array of distances:

array([ 0., 2., 4., 6., 8., 10., 12., 14., 16., 18., 20.])

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/manoharan-lab/holopy/issues/274?email_source=notifications&email_token=AETUFJ4LY7D5U7FPPPISPBDP3JFEPA5CNFSM4HZKYAYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2NWKRA, or mute the thread https://github.com/notifications/unsubscribe-auth/AETUFJZQZY47FHZ3VPNHKYLP3JFEPANCNFSM4HZKYAYA .

briandleahy commented 5 years ago

Fixed by #291