search

manoharan-lab / holopy

Hologram processing and light scattering in python
GNU General Public License v3.0
134 stars 50 forks source link

Transformed priors #372

Closed barkls closed 4 years ago

barkls commented 4 years ago

Documentation on using these new things is lacking. We should have a user guides on Model & Prior objects, and also a tutorial using the new features. I'm happy to get this merged in first though

barkls commented 4 years ago

oh no! I forgot to update the changelog. Don't merge until I do...

pep8speaks commented 4 years ago

Hello @barkls! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 42:1: W293 blank line contains whitespace Line 44:1: W293 blank line contains whitespace Line 336:13: E731 do not assign a lambda expression, use a def Line 338:13: E731 do not assign a lambda expression, use a def

Line 385:80: E501 line too long (88 > 79 characters) Line 386:80: E501 line too long (90 > 79 characters) Line 387:80: E501 line too long (90 > 79 characters) Line 388:80: E501 line too long (94 > 79 characters)

Comment last updated at 2020-10-26 17:56:38 UTC
barkls commented 4 years ago

Thanks for the review @briandleahy! Ready to merge (assuming tests pass)