Closed barkls closed 4 years ago
oh no! I forgot to update the changelog. Don't merge until I do...
Hello @barkls! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
holopy/inference/prior.py
:Line 42:1: W293 blank line contains whitespace Line 44:1: W293 blank line contains whitespace Line 336:13: E731 do not assign a lambda expression, use a def Line 338:13: E731 do not assign a lambda expression, use a def
holopy/inference/tests/test_model.py
:Line 385:80: E501 line too long (88 > 79 characters) Line 386:80: E501 line too long (90 > 79 characters) Line 387:80: E501 line too long (90 > 79 characters) Line 388:80: E501 line too long (94 > 79 characters)
Thanks for the review @briandleahy! Ready to merge (assuming tests pass)
Documentation on using these new things is lacking. We should have a user guides on Model & Prior objects, and also a tutorial using the new features. I'm happy to get this merged in first though