manoharan-lab / holopy

Hologram processing and light scattering in python
GNU General Public License v3.0
131 stars 50 forks source link

HoloPy 3.4.0 release #374

Closed barkls closed 3 years ago

pep8speaks commented 3 years ago

Hello @barkls! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 311:21: E251 unexpected spaces around keyword / parameter equals Line 311:23: E251 unexpected spaces around keyword / parameter equals Line 311:34: E251 unexpected spaces around keyword / parameter equals Line 311:36: E251 unexpected spaces around keyword / parameter equals

Line 55:5: E128 continuation line under-indented for visual indent

Line 51:25: E127 continuation line over-indented for visual indent

Line 42:1: W293 blank line contains whitespace Line 44:1: W293 blank line contains whitespace Line 336:13: E731 do not assign a lambda expression, use a def Line 338:13: E731 do not assign a lambda expression, use a def

Line 263:80: E501 line too long (98 > 79 characters)

Line 175:80: E501 line too long (80 > 79 characters) Line 176:80: E501 line too long (80 > 79 characters) Line 385:80: E501 line too long (88 > 79 characters) Line 386:80: E501 line too long (90 > 79 characters) Line 387:80: E501 line too long (90 > 79 characters) Line 388:80: E501 line too long (94 > 79 characters)

Line 26:48: E251 unexpected spaces around keyword / parameter equals Line 26:50: E251 unexpected spaces around keyword / parameter equals Line 69:42: E203 whitespace before ',' Line 69:43: E231 missing whitespace after ',' Line 69:70: E251 unexpected spaces around keyword / parameter equals Line 69:72: E251 unexpected spaces around keyword / parameter equals Line 75:23: E203 whitespace before ',' Line 75:24: E231 missing whitespace after ',' Line 158:43: E231 missing whitespace after ',' Line 158:49: E261 at least two spaces before inline comment Line 158:50: E262 inline comment should start with '# ' Line 158:80: E501 line too long (87 > 79 characters) Line 235:24: E211 whitespace before '[' Line 235:40: E203 whitespace before ':' Line 235:73: E203 whitespace before ':' Line 235:80: E501 line too long (90 > 79 characters) Line 238:5: E265 block comment should start with '# ' Line 238:5: E303 too many blank lines (2) Line 244:80: E501 line too long (86 > 79 characters) Line 263:80: E501 line too long (111 > 79 characters)

Line 31:80: E501 line too long (80 > 79 characters)

Line 100:29: E225 missing whitespace around operator Line 100:31: E701 multiple statements on one line (colon) Line 100:80: E501 line too long (123 > 79 characters) Line 113:39: E701 multiple statements on one line (colon) Line 113:59: E231 missing whitespace after ',' Line 150:80: E501 line too long (100 > 79 characters) Line 171:80: E501 line too long (98 > 79 characters) Line 198:80: E501 line too long (82 > 79 characters)

Line 171:30: E201 whitespace after '['

Comment last updated at 2020-11-05 21:37:19 UTC
briandleahy commented 3 years ago

This looks good to me. I will merge it in once Travis finishes checking.

And let's ignore the pep8 bot on this, to avoid complications with logs.