Closed briandleahy closed 3 years ago
Hello @briandleahy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
holopy/scattering/theory/mielens.py
:Line 163:1: W391 blank line at end of file
Your comments are addressed in the latest commits. I added a description of the AberratedMieLens theory in fedde9a0. I would appreciate it if you could take a quick look at that and tell me if my documentation is intelligible. Also, in the process I noticed that there were some out-of-date docs; I fixed these in baedc1ff.
Let me know if you have other comments!
Good catch on updating the function names in the dev guide! Everything else looks good except the posision typo
This extends
holopy
with the ability to calculate the image of single spheres through a lens with spherical aberration of arbitrary order, at no extra computational cost compared to that for an unaberrated lens (and therefore still faster than the calculations without a lens).@carolinesmartin has been using this for about 1 year now, so the code has been pretty well stress-tested.
@barkls let me know if this should be added to a user guide.