search

manoharan-lab / holopy

Hologram processing and light scattering in python
GNU General Public License v3.0
134 stars 50 forks source link

Mielensab #386

Closed briandleahy closed 3 years ago

briandleahy commented 3 years ago

This extends holopy with the ability to calculate the image of single spheres through a lens with spherical aberration of arbitrary order, at no extra computational cost compared to that for an unaberrated lens (and therefore still faster than the calculations without a lens).

@carolinesmartin has been using this for about 1 year now, so the code has been pretty well stress-tested.

@barkls let me know if this should be added to a user guide.

pep8speaks commented 3 years ago

Hello @briandleahy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 163:1: W391 blank line at end of file

Comment last updated at 2021-02-22 22:30:34 UTC
briandleahy commented 3 years ago

Your comments are addressed in the latest commits. I added a description of the AberratedMieLens theory in fedde9a0. I would appreciate it if you could take a quick look at that and tell me if my documentation is intelligible. Also, in the process I noticed that there were some out-of-date docs; I fixed these in baedc1ff.

Let me know if you have other comments!

barkls commented 3 years ago

Good catch on updating the function names in the dev guide! Everything else looks good except the posision typo