search

manoharan-lab / holopy

Hologram processing and light scattering in python
GNU General Public License v3.0
131 stars 50 forks source link

Fix #338 and #322 #393

Closed briandleahy closed 3 years ago

briandleahy commented 3 years ago

This PR makes determine_default_theory_for give Mie instead of Multisphere when the spheres are far apart. cf. #338 . There is a large in-line comment explaining the thought process behind the change; let me know if a different approach would be better.

In addition, I also updated the docs to discuss holopy's computational limitations for large particles a bit more. I can expand on that if needed.

pep8speaks commented 3 years ago

Hello @briandleahy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2021-04-06 21:58:52 UTC
barkls commented 3 years ago

closing and reopening to trigger travis build