search

manoharan-lab / holopy

Hologram processing and light scattering in python
GNU General Public License v3.0
131 stars 50 forks source link

Deprecate normals and fitting #399

Closed briandleahy closed 3 years ago

briandleahy commented 3 years ago

This small PR deprecates normals and fitting, as part of #394 .

I will split the deprecations to nmpfit out in a different PR, so we can keep things modular. This PR is modular with respect to nmpfit; as far as I can tell it will have no effects on the nmpfit machinery.

pep8speaks commented 3 years ago

Hello @briandleahy! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 524:80: E501 line too long (97 > 79 characters)

Comment last updated at 2021-05-20 12:56:46 UTC
briandleahy commented 3 years ago

I went on a spree and deleted basically everything related to the inference that could be deprecated (with the exception of nmpfit, which I will do later). I left in the result.best_fit method in with the same descriptive error message, since it is published in the holopy paper. I've also updated the release notes.

Let me know your thoughts.