Closed barkls closed 3 years ago
Hello @barkls! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
holopy/core/io/io.py
Line 519:80: E501 line too long (97 > 79 characters)
holopy/scattering/tests/test_2_color.py
Line 41:31: E231 missing whitespace after ',' Line 41:36: E231 missing whitespace after ',' Line 41:45: E231 missing whitespace after ',' Line 111:29: E231 missing whitespace after ',' Line 111:47: E231 missing whitespace after ',' Line 111:66: E231 missing whitespace after ','
holopy/scattering/tests/test_imageformation.py
Line 202:22: E203 whitespace before ',' Line 208:22: E203 whitespace before ',' Line 208:34: E203 whitespace before ',' Line 209:22: E203 whitespace before ',' Line 210:46: E203 whitespace before ',' Line 211:58: E203 whitespace before ',' Line 212:70: E202 whitespace before ']' Line 214:22: E203 whitespace before ',' Line 215:22: E203 whitespace before ',' Line 216:22: E203 whitespace before ',' Line 217:22: E203 whitespace before ',' Line 217:46: E203 whitespace before ',' Line 218:22: E203 whitespace before ',' Line 232:15: E203 whitespace before ',' Line 232:20: E203 whitespace before ',' Line 232:25: E203 whitespace before ',' Line 232:30: E203 whitespace before ',' Line 232:35: E203 whitespace before ',' Line 235:15: E203 whitespace before ',' Line 235:40: E203 whitespace before ',' Line 235:65: E203 whitespace before ',' Line 236:30: E203 whitespace before ',' Line 236:55: E203 whitespace before ',' Line 274:38: E203 whitespace before ',' Line 274:52: E202 whitespace before ']' Line 276:52: E202 whitespace before ']' Line 277:38: E203 whitespace before ','
holopy/scattering/theory/mielensfunctions.py
Line 376:13: E741 ambiguous variable name 'l' Line 382:80: E501 line too long (80 > 79 characters) Line 393:17: E741 ambiguous variable name 'l'
@briandleahy we have GitHub configured to require an approving review before merging. Can you do the hono(u)rs once Travis passes?
Hello @barkls! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
holopy/core/io/io.py
:holopy/scattering/tests/test_2_color.py
:holopy/scattering/tests/test_imageformation.py
:holopy/scattering/theory/mielensfunctions.py
: