manoharan-lab / structural-color

Python package for modeling structural color in colloidal systems
GNU General Public License v3.0
16 stars 11 forks source link

Removed fine roughness parameter from det.calc_refl_trans() #95

Closed victoriahwang89 closed 4 years ago

victoriahwang89 commented 4 years ago

Previously, the Fresnel reflection of the incident light was calculated from n_medium to n_matrix when there was fine roughness in calc_refl_trans(). When there wasn't fine roughness, the Fresnel coefficient was calculated from n_medium to n_sample. Now, the Fresnel coefficient is always calculated from n_medium to n_sample, regardless of whether there's fine roughness. This is more consistent with the interpretation of the fine_roughness as a "correction" factor that corrects for the invalidity of effective medium theory at the interface. The previous implementation of Fresnel implied that fine roughness changed the physics of reflection, which is harder to argue if we consider the fine roughness to be simply a correction factor.

Updated corresponding tests and tutorials.