search

manojkarthick / pqrs

Command line tool for inspecting Parquet files
Apache License 2.0
283 stars 27 forks source link

Moved cat "header" to stderr for easier piping #21

Closed juan-riveros closed 2 years ago

juan-riveros commented 2 years ago

Fixes Issue #20 by moving the cat "header" to stderr instead of stdout to allow for piping.

Feel free to reject this if you think that a --quiet flag might be a better option.

manojkarthick commented 2 years ago

Thanks @juan-riveros - this looks great! I think it's okay to move the header to stderr. The tests seem to be failing though, would you be able to take a look?

juan-riveros commented 2 years ago

There that should do it. Had to change two tests since they assumed that the header existed in stdout. One assumed the output would be surrounded by newlines so just removed the newlines from the predicate and the other checked for filenames in stdout so changed it checking against stderr instead.

manojkarthick commented 2 years ago

Awesome. Thanks a lot for contributing!