Open GoogleCodeExporter opened 9 years ago
my changes:
- included SDL.dll in NSI-Script
- removed a define
- error handling for win32 files (r501)
Not in the patch:
- remove raw.cpp/h, pcx.cpp/h from VS-Solution files (r502,r503)
Original comment by tino.mie...@gmail.com
on 29 Apr 2008 at 10:34
Attachments:
Thanks for the patch!
Please take note for the future that there is a quota of 50 MB for attachments
(in
the whole system!), so that it shouldn't be used for large binaries, as much as
possible (especially on the initial submission, which cannot be deleted). In
this
particular case, I don't think it is even of much use?
The patch, though, is quite welcome, thanks!
Original comment by pphaneuf
on 29 Apr 2008 at 3:09
Yeah, sorry for the big binary. Feel free to delete it from the issuetracker
(devs
should be able to do this, or?).
I've tried to make a site in the wiki for it, but it seems only project
developer can
edit the wiki.
Another suggestion:
in the readme-win32.txt is still a passage about DirectX, perhaps with SDL it is
obsolete?
Original comment by tino.mie...@gmail.com
on 29 Apr 2008 at 7:50
No, even project admins can't delete anything on Google Code (they want to keep
the
history of everything, it's only possible in cases of abuse), I just asked.
They did
crank up the project's quota for issues attachments by 25 MB, so no worries. ;-)
Making an issue and attaching the patch is indeed the best way to send
contributions
our way.
Note that you called your build 1.2, but the SDL branch is going to be 1.3,
actually.
The plan is that 1.3.x will be "unstable" development versions, for daring
people
willing to endure some bugginess in order to try out new features, test them
and give
us feedback.
You meant making a page in the wiki on the subject of the SDL branch? We're not
using
the wiki much, and the way it works on Google Code is apparently not as open as
wikis
are on other sites (people that are not members of projects can leave comments
on
existing wiki pages, that's it). We're using the discussion groups more, for
what
it's worth, feel free to join them and take part in the project!
Our current focus is on releasing 1.2 (the trunk version), so yeah, it's
possible
that readme-win32.txt is out of date with regard to the SDL branch. I'll file an
issue to fix this, so we don't forget.
Original comment by pphaneuf
on 29 Apr 2008 at 10:07
Original issue reported on code.google.com by
tino.mie...@gmail.com
on 29 Apr 2008 at 9:54Attachments: