Closed cwayfinder closed 9 years ago
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.
lib/com/vaadin/polymer/elemental/NodeList.java, line 7 [r1] (raw file): I would not use generics for this interface, which could make it more restrictive. I would let the generic T extends Node in the item method
Comments from the review on Reviewable.io
Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.
lib/com/vaadin/polymer/elemental/NodeList.java, line 7 [r1] (raw file): Done.
Comments from the review on Reviewable.io
Reviewed 1 of 2 files at r2. Review status: 1 of 3 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.
lib/com/vaadin/polymer/elemental/NodeList.java, line 7 [r1] (raw file):
You can remove
Comments from the review on Reviewable.io
Reviewed 1 of 3 files at r1, 1 of 1 files at r3. Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.
Comments from the review on Reviewable.io