search

manolo / gwt-api-generator

Generator for creating GWT JSInterop clients from Polymer Web Components
Apache License 2.0
50 stars 24 forks source link

Ambiguous 'setSelected' on PaperMenu / PaperTabs / PaperListbox / PaperRadioGroup #66

Closed ghost closed 8 years ago

ghost commented 8 years ago

The signature for the getter / setter of selected has been changed from Stringto Object But there ist still a method setSelected(String) doing getPolymerElement().setAttribute("selected", value); instead of getPolymerElement().setSelected(value);

This can cause wrong behave if the menu should have no selection with: setSelected(null)

cpboyd commented 8 years ago

Ultimately, this has to do with how the Java setters are generated.

See the Widget template, line 78: https://github.com/vaadin/gwt-api-generator/blob/master/template/Widget.template#L78