manolo / gwt-api-generator

Generator for creating GWT JSInterop clients from Polymer Web Components
Apache License 2.0
50 stars 24 forks source link

Add model.item to Event #78

Open ghost opened 7 years ago

ghost commented 7 years ago

Declarative event handlers inside a "dom-repeat" add the model object to the event. If we make the model available on the elemental.Event then it is possible to get the data from the item when an event is fired.

@JsType(isNative=true, namespace=GLOBAL)
public interface Event {
     ....

    @JsProperty TemplateInstance getModel();

    @JsType(isNative=true, namespace=GLOBAL)
    public interface TemplateInstance {
        @JsProperty <T> T getItem();
    }
}

Example: So if the "dom-repeat" template contains an event handler (a.e. <paper-button on-tap="onTapFct">) then we get the binded data on each event.

Polymer.function(bindTemplate, "onTapFct", event -> {
    Foo foo = ((Event) event).getModel().getItem();
});

final List<Foo> data = createData();
repeatTemplate.setItems(Polymer.asJsArray(data));
ibaca commented 7 years ago

IMO Accessing to this field using some static utility make much more sense. The model is only available if the handler is in a dom-repeat, this cannot be expressed using the type-system so it just better to force the user to call the method itself. This actually matches perfectly with the alternative strategy proposed by polymer this.$.domRepeat.modelForElement(event.target).