search

manolo / gwt-api-generator

Generator for creating GWT JSInterop clients from Polymer Web Components
Apache License 2.0
50 stars 24 forks source link

Allow using Webcomponents.js 1.x #86

Open wdkuc opened 6 years ago

wdkuc commented 6 years ago

This change is Reviewable

manolo commented 6 years ago

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

lib/com/vaadin/polymer/Polymer.java, line 51 at r1 (raw file):

     */
    @JsProperty(namespace = JsPackage.GLOBAL)
    public static native void setWebcomponentsJsLocation(String s);

Any reason for publishing this variable in window scope? I think just a static string in this class might be enough

Comments from Reviewable

manolo commented 6 years ago

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

lib/com/vaadin/polymer/Polymer.java, line 67 at r1 (raw file):

        }
        if(getWebcomponentsJsLocation() == null) {
            setWebcomponentsJsLocation("webcomponentsjs/webcomponents-lite.min.js");

shouldn't it be webcomponents-lite.js instead ?

Comments from Reviewable

vegegoku commented 6 years ago

in my other PR i renamed the file, since the webcomponents-lite.min.js is not there anymore.