manolomartinez / greg

A command-line podcast aggregator
GNU General Public License v3.0
299 stars 37 forks source link

PKGBuild Versionnumber #11

Closed Narrat closed 11 years ago

Narrat commented 11 years ago

Hi

Not a real issue so far. But I noticed something. git describe just shows as default the last signed tag or annotated one, but not the lightweight one.

Your latest tag ist 0.3.0 But $ git describe --always | sed -e 's|-|.|g' will print 0.1.0.44.ga3d5ed6 for me which is not quite right.

If the --tags option is added it will show: $ git describe --tags --always | sed -e 's|-|.|g' 0.3.0.6.ga3d5ed6 Which is the intended version. (before the commit count and the hash for the last commit)

Narrat commented 11 years ago

Gnah.. Looking at the diff it created it's probably better you close this request and make the change yourself, if you want to. This commit looks stupid... I only changed one line