manolomartinez / greg

A command-line podcast aggregator
GNU General Public License v3.0
299 stars 37 forks source link

Existing podcasts #6

Closed Narrat closed 11 years ago

Narrat commented 11 years ago

Maybe it could be checked before the download starts, if a podcast-file is already existing in the download folder?

manolomartinez commented 11 years ago

Hi, just to make sure: these are podcasts that you have antecedently downloaded with another tool, right? It's not that Greg is downloading some podcasts twice?

Otherwise, I don't think that would be a good idea: you might want to delete your podcasts once you listen to them, and you wouldn't want Greg to download those again, for example.

Narrat commented 11 years ago

Yes. Those podcasts existed before and weren't downloaded with greg. But I invoked instead of check sync and it started to download the files (which is ok). But it ignored, that those files already existed in the location where it downloads the files (not so ok, imo). That's somewhat unnecessary :)

And well.. I can't quite follow your point in the second paragraph. Maybe I'm missing some greg feature?

manolomartinez commented 11 years ago

Oh, sorry, I misunderstood you. I thought you meant that greg should check whether a podcast already existed and refrain from downloading it if it did. You simply mean that greg should not overwrite existing files. Yes, that's surely the right thing to do :) I'm on it!

manolomartinez commented 11 years ago

The tip of the development branch doesn't overwrite existing files now. It also introduces custom download handlers in greg.conf. If you can, take a look at it, and let me know what you think.

Narrat commented 11 years ago

Nice and thanks :) I will look into it and write a comment then

Edit (some minutes later): Yes, it works. Existing files won't be overwritten

manolomartinez commented 11 years ago

You can now also use, e.g., wget to download files; enabling time-stamping you can instruct greg to completely avoid downloading a new copy of an existing file.

Narrat commented 11 years ago

Sounds even better :) I'll check it out