Project Feedback

[manotejmeka]

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] The files from your last project are copied and pasted into the directory for this project
• [x] Your code returns no errors (warnings are OK) when pasted into the W3C Validator (this will also be expected for all future projects)
• [x] Consistent spacing and indentation are used on every line (this will also be expected for all future projects)
• [x] skeleton.css is used to improve the design of the page

[egillespie]

Looking good so far. The skeleton.css that we intended you to use for this project is the one referenced on the last page of this lesson:

https://cdnjs.cloudflare.com/ajax/libs/skeleton/2.0.4/skeleton.css

Do you mind removing the skeleton.css that you're using and instead reference the one above? After you push to master and gh-pages, @mention me and I'll take another look.

Thanks!

[manotejmeka]

@egillespie I have made the changes you have asked for. I hope that is what you meant by having skeleton.css file as well as styling in the document. I could of just added my styling in the skeletion.css but I just added a new file so that you know the changes I made to the original file.

[egillespie]

I think I explained it poorly. The change involves replacing these two lines:

  <link rel="stylesheet" href="styling.css">
  <link rel="stylesheet" href="skeleton.css">

With this:

  <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/skeleton/2.0.4/skeleton.css">

Then you can delete the styling.css and skeleton.css files in your project.

[manotejmeka]

@egillespie Okay done made those changes. I think I am just too much when it is not needed. haha. Sorry!!

[egillespie]

Looks great! And don't worry, we'll be working on communicating goals of projects better over the course of the semester.

:shipit: