manotejmeka / MI-449-SS17-741-js-create-an-api-with-express-URJy-_

0 stars 0 forks source link

Project Feedback #1

Open manotejmeka opened 7 years ago

manotejmeka commented 7 years ago

Create a todo list API

@stuartpearman Can you take a look at this? It's hosted here and meets the following criteria:

The project is not finished fully. I am having some problems and I am pushing code to show you what I have. I am having some problems with the postman software and how to debug it

manotejmeka commented 7 years ago

https://mekamano-khxn-8th0o-1eurjy-.herokuapp.com/ That is is link to my heroku the underlines has some problems

stuartpearman commented 7 years ago

Hi Manotej, your 404's don't seem to be working. Your todos/:id route seems to have a duplicate, and your main 404 still needs to be made as far as I can tell.

Let me know when you've made changes 😎

stuartpearman commented 7 years ago

Also, your POST request times out, and the PUT request redirects to a unknown path.

manotejmeka commented 7 years ago

@stuartpearman Everything should be fixed now

stuartpearman commented 7 years ago

Hi Manotej, your API still doesn't handle all unknown paths. If I try GET /kjadnlkdjfnas, I should also get a 404 response. Check the 404 slide of the lesson for details.

manotejmeka commented 7 years ago

@stuartpearman I had that code in, but I think I must have forgotten to push the code. Sorry

stuartpearman commented 7 years ago

Sweet. Congrats Manotej, you're done! :shipit:

It's been awesome having you in class sir. You're a great developer and Microsoft is lucky to have you. Enjoy the summer 🌞