search

manrajgrover / SingleDivProject

☝️One <div>. Many possibilities.
MIT License
1.59k stars 105 forks source link

Support SVG assets #65

Open module17 opened 8 years ago

module17 commented 8 years ago

Prefer SVG over PNG; as it could be reused and controlled for consistency. Could we figure out how to get the SVG assets to display correctly in the README.md on Github. I tried to pull the SVG from "rawgithub" with no luck. This SVG support implementation seems to be changing constantly.

Any thoughts?

manrajgrover commented 8 years ago

@module17 Apart from getting it to work in README.md, we should also think about converting current elements to SVG. It is a challenge in itself.

module17 commented 8 years ago

@ManrajGrover I got my SVG asset from Wikipedia. I believe the license allows for such inclusion. They probably have every flag - Perhaps we link right to them? I have not explored the licenses too deeply.

module17 commented 8 years ago

@ManrajGrover See my closed PR https://github.com/ManrajGrover/SingleDivProject/pull/30

module17 commented 8 years ago

On second thought... perhaps SVG is too much of a requirement. After all, this is a single div project, perhaps SVG / XML markup takes away from the concept.