Closed leereilly closed 6 years ago
Hi! Just a small PR for your consideration that pluralizes match in one of the error messages. The plural form sounds better (to me at least) and this keeps it consistent with other error messages e.g. scores here: https://github.com/ManrajGrover/football-cli/blob/b2135335aeb837775f88cfd5111e937a3ef5851a/helpers.js#L150
match
scores
$ football scores -l SA Sorry, no live match right now
$ football scores -l SA Sorry, no live matches right now
/cc @ManrajGrover ⚽️
@leereilly This should have been fixed in 0.14.8. Please let me know if it isn't.
0.14.8
Hi! Just a small PR for your consideration that pluralizes
match
in one of the error messages. The plural form sounds better (to me at least) and this keeps it consistent with other error messages e.g.scores
here: https://github.com/ManrajGrover/football-cli/blob/b2135335aeb837775f88cfd5111e937a3ef5851a/helpers.js#L150Before
After
/cc @ManrajGrover ⚽️