search

manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter
MIT License
2.86k stars 148 forks source link

OTHERS: Fix linting issues #100

Closed eoinnoble closed 5 years ago

eoinnoble commented 5 years ago

Description of new feature, or changes

Mainly removing whitespace and reordering imports, but also trying to get rid of bare except occurrences. I also added .DS_Store to the .gitignore for Mac users.

You don't appear to use flake8 in your linting process but some of these issues seemed to violate PEP8 so I wanted to fix them, even if only so that the warnings disappear in my own environment!

I am only able to run the py36 tests at present, and they do not currently pass for me (see my other PR for a fix for that test). To keep this PR clean I have left them like that.

Checklist

People to notify

@manrajgrover

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 287

Totals Coverage Status
Change from base Build 285: 0.6%
Covered Lines: 272
Relevant Lines: 289
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 287

Totals Coverage Status
Change from base Build 285: 0.6%
Covered Lines: 272
Relevant Lines: 289
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 287

Totals Coverage Status
Change from base Build 285: 0.6%
Covered Lines: 272
Relevant Lines: 289
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 290

Totals Coverage Status
Change from base Build 289: 0.0%
Covered Lines: 272
Relevant Lines: 289
💛 - Coveralls