Fixes #102: allow exceptions to bubble up w/ ctxmgr & decorator

manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter

MIT License

2.86k stars 148 forks source link

Fixes #102: allow exceptions to bubble up w/ ctxmgr & decorator #106

Closed theY4Kman closed 5 years ago

theY4Kman commented 5 years ago

Description

This PR foregoes returning a value from __exit__, thereby allowing exceptions raised inside the context manager to bubble up. Since the decorator also utilizes the context manager, exceptions will bubble up from decorated methods as well.

Checklist

[X] Your branch is up-to-date with the base branch
[X] You've included at least one test if this is a new feature
[X] All tests are passing

Related Issues and Discussions

Resolves #102

People to notify

@manrajgrover

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 302

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.157%

Totals
Change from base Build 291:	0.0%
Covered Lines:	272
Relevant Lines:	289

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 302

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.157%

Totals
Change from base Build 291:	0.0%
Covered Lines:	272
Relevant Lines:	289

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 306

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.157%

Totals
Change from base Build 304:	0.0%
Covered Lines:	272
Relevant Lines:	289