manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter
MIT License
2.86k stars 148 forks source link

Fixes #110: Prevent UnicodeEncodeError #111

Closed alarreine closed 5 years ago

alarreine commented 5 years ago

Description of new feature, or changes

Fix #110

Checklist

Related Issues and Discussions

Resolves #110

People to notify

@manrajgrover

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 342


Totals Coverage Status
Change from base Build 337: -0.8%
Covered Lines: 289
Relevant Lines: 313

💛 - Coveralls
manrajgrover commented 5 years ago

@alarreine Thanks for raising the issue and for the fix! 😄

You would need to add tests for this bug fix before this can be merged. Let me know if you need any assistance.

alarreine commented 5 years ago

Hi @manrajgrover I added the test in commit a26b58d