BUG FIX: fix python 3.6+ compatibility - Githubissues

manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter

MIT License

2.89k stars 147 forks source link

BUG FIX: fix python 3.6+ compatibility #115

Closed lstolcman closed 5 years ago

lstolcman commented 5 years ago

Description of new feature, or changes

Python 3.6 introduced new package "enum". Due to an old version of subpackage (https://github.com/manrajgrover/py-log-symbols), old "enum34" is used which is in conflict with python 3.6 ad higher. Pull request updates the library to the newest version, which fixes the problem

See also: https://stackoverflow.com/questions/43124775/why-python-3-6-1-throws-attributeerror-module-enum-has-no-attribute-intflag and first answer

Checklist

[x] Your branch is up-to-date with the base branch
[ ] You've included at least one test if this is a new feature
[ ] All tests are passing

Lint test is failing, but it is not relevant with the change

Related Issues and Discussions

https://github.com/manrajgrover/py-log-symbols/issues/14

People to notify

@manrajgrover

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 349

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.231%

Totals
Change from base Build 346:	0.0%
Covered Lines:	289
Relevant Lines:	313

💛 - Coveralls

manrajgrover commented 5 years ago

Thanks for this @lstolcman!

manrajgrover commented 5 years ago

@lstolcman This was released today in 0.0.23