BUG FIX: Prevent python3 unicode error when reading long_description

manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter

MIT License

2.86k stars 148 forks source link

BUG FIX: Prevent python3 unicode error when reading long_description #117

Closed juledwar closed 5 years ago

juledwar commented 5 years ago

The long_description is pulling from README.md, which has a unicode character in it. This sometimes causes Python 3 installations to fail with a UnicodeDecodeError if the locale setting is mismatched with the file encoding (as is the case when installing to a container). The solution is to force the encoding at the time the file is opened.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 357

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.231%

Totals
Change from base Build 355:	0.0%
Covered Lines:	289
Relevant Lines:	313

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 351

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.231%

Totals
Change from base Build 350:	0.0%
Covered Lines:	289
Relevant Lines:	313

💛 - Coveralls

juledwar commented 5 years ago

Hi, can you consider merging this please?

manrajgrover commented 5 years ago

Hi @juledwar,

Thank you for working on this and really sorry for the late reply. I just merged https://github.com/manrajgrover/halo/pull/125 which should fix this. I'm making a release in some time. Will share the version here. Closing this as it should be fixed now.