manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter
MIT License
2.89k stars 147 forks source link

FIXES #81: Add tests to verify ANSI codes are in the spinner output #119

Closed eoinnoble closed 5 years ago

eoinnoble commented 5 years ago

Description of new feature, or changes

As in my other PR for halo I've added pretty much the same test for halo notebook. _get_test_output has been refactored to take a no_ansi arg, which defaults to True. We then use this in the new test to keep the ANSI escape characters and compare them to those supplied by colorama.

I also cleared up an un-needed import in the other test file.

Sorry it took me a while to get to!

Checklist

Related Issues and Discussions

81

People to notify

@manrajgrover

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 397


Totals Coverage Status
Change from base Build 396: 0.0%
Covered Lines: 306
Relevant Lines: 330

💛 - Coveralls