Upgrade to six==1.12.0 - Githubissues

cSchubes commented 5 years ago

Description

Can Halo be upgraded to use six version 1.12.0? The tensorflow pip package depends on 1.12.0, making it completely incompatible with halo.

cSchubes commented 5 years ago

Tested on Ubuntu 18.04 with six 1.12.0, seems to be compatible

manrajgrover commented 5 years ago

@cSchubes Certainly! Would you like to raise the PR for it? Do make sure the test cases pass.

Also, apologies for late replies. I'm in the middle of switching roles, hence the delay.

cSchubes commented 5 years ago

Output from running python -m unittest test_halo:

/home/carson/tsl/halo/tests/test_halo.py:518: DeprecationWarning: Please use assertEqual instead.
  self.assertEquals("bounce", spinner.animation)
./home/carson/anaconda3/envs/raven/lib/python3.6/unittest/suite.py:107: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/carson/tsl/halo/tests/test.txt' mode='w+' encoding='UTF-8'>
  for index, test in enumerate(self):
......../home/carson/tsl/halo/tests/test_halo.py:339: DeprecationWarning: Please use assertRegex instead.
  self.assertRegexpMatches(output[-1], pattern)
........./home/carson/tsl/halo/tests/test_halo.py:527: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/carson/tsl/halo/tests/test.txt' mode='w+' encoding='UTF-8'>
  self._stream = io.open(self._stream_file, 'w+')  # reset stream
......../home/carson/tsl/halo/tests/test_halo.py:104: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/carson/tsl/halo/tests/test.txt' mode='w+' encoding='UTF-8'>
  self._stream = io.open(self._stream_file, 'w+')
....
----------------------------------------------------------------------
Ran 32 tests in 21.525s

OK

cSchubes commented 5 years ago

will make PR now!

manrajgrover / halo

Upgrade to six==1.12.0 #120

Description