BUG: Halo install requires UTF-8 locale to be set

manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter

MIT License

2.86k stars 148 forks source link

BUG: Halo install requires UTF-8 locale to be set #125

Closed adamtheturtle closed 5 years ago

adamtheturtle commented 5 years ago

Description of new feature, or changes

See #124 for the issue that this fixes. This change has been tested with the test set out in that issue.

Checklist

[X] Your branch is up-to-date with the base branch
[X] You've included at least one test if this is a new feature: This is not a new feature.
[ ] All tests are passing: I hope they will!

Related Issues and Discussions

Fixes #124 .

People to notify

@manrajgrover

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 370

0 of 0 changed or added relevant lines in 0 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.5%) to 88.689%

Files with Coverage Reduction	New Missed Lines	%
halo/halo.py	2	91.97%
halo/_utils.py	4	70.49%
<!--	Total:	6	-->

Totals
Change from base Build 355:	-1.5%
Covered Lines:	283
Relevant Lines:	313

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 370

0 of 0 changed or added relevant lines in 0 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.5%) to 88.689%

Files with Coverage Reduction	New Missed Lines	%
halo/halo.py	2	91.97%
halo/_utils.py	4	70.49%
<!--	Total:	6	-->

Totals
Change from base Build 355:	-1.5%
Covered Lines:	283
Relevant Lines:	313

💛 - Coveralls

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 371

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.231%

Totals
Change from base Build 355:	0.0%
Covered Lines:	289
Relevant Lines:	313

💛 - Coveralls

juledwar commented 5 years ago

I think my fix still has something you need - it ensures the README is opened read-only, which is missing from the old code and #125

Thanks for sorting it out anyway!

manrajgrover commented 5 years ago

@juledwar Ah, makes sense. I'll make that change in some time. For now, I've made the release for this.

https://pypi.org/project/halo/0.0.24/

juledwar commented 5 years ago

@manrajgrover Thanks! Is there any chance you can release log-symbols 0.0.13 as well and release Halo again to use it? It has the important enum34 fix!

manrajgrover commented 5 years ago

@juledwar Looking into it. Thanks for pointing it out. I've been a lot occupied lately and had decided to squash and sort out everything today. :smile:

manrajgrover commented 5 years ago

@juledwar Made a release and updated halo to v0.0.25! This should be fixed now.