manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter
MIT License
2.86k stars 148 forks source link

Use _write in stop_and_persist #131

Closed ushpizin closed 4 years ago

ushpizin commented 4 years ago

Description of new feature, or changes

I noticed that the method Halo._write is used everywhere, except in Halo._stop_and_persist, where the string is written directly to the _stream.

In pytest the output is captured and the stream gets closed after the test, so this fix was critical for me.

Checklist

Related Issues and Discussions

People to notify

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 408


Changes Missing Coverage Covered Lines Changed/Added Lines %
halo/halo.py 1 2 50.0%
<!-- Total: 1 2 50.0% -->
Totals Coverage Status
Change from base Build 406: 0.0%
Covered Lines: 306
Relevant Lines: 330

💛 - Coveralls
manrajgrover commented 4 years ago

@ushpizin Thanks for working on this. LGTM! Can you bump the version as well before I merge this?

ushpizin commented 4 years ago

Sure 👍