Closed ushpizin closed 4 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
halo/halo.py | 1 | 2 | 50.0% | ||
<!-- | Total: | 1 | 2 | 50.0% | --> |
Totals | |
---|---|
Change from base Build 406: | 0.0% |
Covered Lines: | 306 |
Relevant Lines: | 330 |
@ushpizin Thanks for working on this. LGTM! Can you bump the version as well before I merge this?
Sure 👍
Description of new feature, or changes
I noticed that the method
Halo._write
is used everywhere, except inHalo._stop_and_persist
, where the string is written directly to the _stream.In pytest the output is captured and the stream gets closed after the test, so this fix was critical for me.
Checklist
Related Issues and Discussions
People to notify