manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter
MIT License
2.86k stars 148 forks source link

add windows terminal support #138

Open t-makaro opened 4 years ago

t-makaro commented 4 years ago

Description of new feature, or changes

Adds support for all spinners when using windows terminal.

Note: If using jupyter notebook spawned from windows terminal, when all characters display correctly. If using jupyter notebook not spawned from WT, then the characters display fallbacks dispite not needing them. HaloNotebook could just patch the is_supported call``` to ignore it, but that would not work as well for LogSymbols.

Checklist

Related Issues and Discussions

Fixes #5

People to notify

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 425


Changes Missing Coverage Covered Lines Changed/Added Lines %
halo/_utils.py 2 3 66.67%
<!-- Total: 2 3 66.67% -->
Totals Coverage Status
Change from base Build 422: 1.5%
Covered Lines: 307
Relevant Lines: 331

💛 - Coveralls