fixed overwrite of spinner value with default spinner in Jupyter Notebooks running on Windows

norweeg commented 4 years ago

Description of new feature, or changes

Removed check of OS causing spinner value to be overwritten with default value in Jupyter Notebook on Windows. If you went to the trouble to use HaloNotebook, you are almost certainly using a browser-based notebook capable of rendering the spinner

Resolves #141

Checklist

[ ] Your branch is up-to-date with the base branch
[ ] You've included at least one test if this is a new feature
[ ] All tests are passing

Related Issues and Discussions

People to notify

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 430

8 of 9 (88.89%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 90.802%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
halo/halo_notebook.py	8	9	88.89%
<!--	Total:	8	9	88.89%	-->

Totals
Change from base Build 429:	-0.2%
Covered Lines:	313
Relevant Lines:	338

💛 - Coveralls

norweeg commented 1 year ago

made obsolete by #144

manrajgrover / halo

fixed overwrite of spinner value with default spinner in Jupyter Notebooks running on Windows #142