update check for Unicode support

norweeg commented 4 years ago

Description of new feature, or changes

~~removes unnecessary system check for Unicode output~~ changes Unicode support check to instead use the encoder supported by sys.stdout to try to encode a Unicode character. If it succeeds, Unicode is supported, otherwise it is not

resolves #5 resolves #25 resolves #141 obsoletes #142

see https://github.com/manrajgrover/halo/issues/5#issuecomment-596145486

Checklist

[x] Your branch is up-to-date with the base branch
[x] You've included at least one test if this is a new feature
[ ] All tests are passing

Related Issues and Discussions

People to notify

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 432

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals
Change from base Build 429:	0%
Covered Lines:
Relevant Lines:	0

💛 - Coveralls

norweeg commented 1 year ago

@manrajgrover can you take a look at this?? AppVeyor is failing not on my code change, but at the environment setup for Python 3.7. It can't install pywinpyt which must be a dependency of something required for testing because a Go compiler is not installed on the test server. I believe once that problem is resolved, all tests will pass

manrajgrover / halo