manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter
MIT License
2.9k stars 149 forks source link

setup.py: Add classifiers and python_requires #150

Closed vilhelmprytz closed 4 years ago

vilhelmprytz commented 4 years ago

Description of new feature, or changes

I have added a list of classifiers to the setup.py. This is mostly metadata but will make it easier to see what versions are supported. Also added python_requires which blocks older versions. I have assumed that Halo does not support versions older than 3.4. If this is incorrect it should be fairly easily adjustable.

Checklist

Related Issues and Discussions

Currently, Halo shows up as "not python 3 compatible" on sites like pyup.io. I am aiming to solve this problem.

People to notify

N/A

vilhelmprytz commented 4 years ago

Is the Travis check misconfigured here? It hasn't been triggered at all.

vilhelmprytz commented 4 years ago

Any news regarding this?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 444


Totals Coverage Status
Change from base Build 440: 0.0%
Covered Lines: 302
Relevant Lines: 356

💛 - Coveralls
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 443


Totals Coverage Status
Change from base Build 440: 0.0%
Covered Lines: 302
Relevant Lines: 356

💛 - Coveralls
manrajgrover commented 4 years ago

Thanks @vilhelmprytz !

vilhelmprytz commented 4 years ago

@manrajgrover Have you pushed to PyPI yet? You should use GitHub releases so that you can via your CI automatically build and push to PyPI upon release :+1:

manrajgrover commented 4 years ago

I've made a release on PyPI.

https://pypi.org/project/halo/0.0.31/

I haven't explored CI for releases. I'll have a look for future releases.

Thanks again!