manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter
MIT License
2.86k stars 148 forks source link

BUG FIX: Fix colors in jupyter by only using colorama on windows #164

Closed samsamoa closed 1 year ago

samsamoa commented 2 years ago

Description of new feature, or changes

Initializing colorama wraps stdout and stderr, and causes color-printing to no longer work in jupyter. Since colorama is only necessary on Windows, this PR makes it so we don't initialize it except on Windows.

image

Checklist

Related Issues and Discussions

Here's a related PR on tqdm: https://github.com/tqdm/tqdm/issues/178