Demos: Move demo gifs to svg based demos

manrajgrover / halo

💫 Beautiful spinners for terminal, IPython and Jupyter

MIT License

2.86k stars 148 forks source link

Demos: Move demo gifs to svg based demos #95

Closed 0scarB closed 5 years ago

0scarB commented 5 years ago

Description of new feature, or changes

Changes demo GIFs to SVGs in the README.md using SVGs generated by svg-term-cli.

Checklist

[x] Your branch is up-to-date with the base branch ~- [ ] You've included at least one test if this is a new feature~
[x] All tests are passing

Related Issues and Discussions

Resolves #37

People to notify

@manrajgrover

manrajgrover commented 5 years ago

@0scarB Hi, thanks for fixing this. There seems to be a gap between emoticons and text. Is it normal or something wrong in the code?

0scarB commented 5 years ago

No problem :smiley: I thinks the gap might have something to do with the glyphs in the font svg-term-cli is using i.e. some glyphs are wider than other.

manrajgrover commented 5 years ago

@0scarB Can you remove the extra space in example codes and generate the SVG again? This will help keep text aligned.

https://github.com/manrajgrover/halo/blob/master/examples/doge_spin.py#L24

0scarB commented 5 years ago

Good suggestion :+1: Let me know what you think about the result.